Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source generator test improvements #758

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Source generator test improvements #758

merged 2 commits into from
Mar 10, 2021

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Mar 9, 2021

Implements two specific changes from #754:

@sharwell sharwell requested a review from a team as a code owner March 9, 2021 20:57
@sharwell
Copy link
Member Author

sharwell commented Mar 9, 2021

@naminodarie please review these improvements to two of your issues

@kzrnm
Copy link
Contributor

kzrnm commented Mar 10, 2021

These improvements looks to good.

In addition, I also want GeneratedSources.

#754 (comment)

@sharwell
Copy link
Member Author

In addition, I also want GeneratedSources.

Me too, but it's a bigger change so I'm leaving it for a separate change.

@sharwell sharwell merged commit 01f1c94 into dotnet:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @kzrnm @jmarolf