Add package reference for System.Net.Http #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosifne
requested review from
jmarolf and
sharwell
and removed request for
a team
sharwell
reviewed
Sep 20, 2021
sharwell
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround to fix issues:
https://devdiv.visualstudio.com/DevDiv/_componentGovernance/112744/alert/2980237?typeId=6257816
https://devdiv.visualstudio.com/DevDiv/_componentGovernance/112744/alert/3537864?typeId=6257816
Roslyn-SDK is not using System.Net.Http packages, but because System.Net.Http is involved in NetStandard.Library 1.6.1, and it is restored by default by all NetStandard projects (which includes our projects, and many other libraries)
Explicitly add System.Net.Http 4.3.4 would fix it.
Apparently, the security check tool should not report this, but it is going to block the build starts from 9/30 so we might need this workaround.