Fix long commands breaking component debugger: #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chsienki
commented
Oct 19, 2021
chsienki
commented
- Write command lines out to a response file
- Pass response file to csc instead of raw arguments
- Make component IDisposable and remove file on dispose
- Write command lines out to a response file - Pass response file to csc instead of raw arguments - Make component IDisposable and remove file on dispose
chsienki
commented
Oct 19, 2021
| settings.Arguments = string.Join(" ", args); | ||
| // write the command line args out to a response file | ||
| var file = GetResponseFileName(); | ||
| File.WriteAllText(file, string.Join(" ", args)); |
There was a problem hiding this comment.
Note that this could throw, but for now I'm just letting VS handle it which gives the following experience:
We have #728 to track handling errors in a more thoughtful way.
|
Ping @dotnet/roslyn-sdk for review please :) |
jmarolf
approved these changes
Oct 20, 2021
|
@jmarolf Yeah, this got punted out of 17.0 due to time constraints. |
This comment has been minimized.
This comment has been minimized.
|
@chsienki I had to merge main into this PR to get the build to use the correct image (where integration tests run). Feel free to rebase if you prefer to have it just be one commit (or let me know and I'm happy to do it myself). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.