Prevent IDE0290 in ref struct

dotnet · Jun 6, 2024 · 029eda1 · 029eda1
1 parent e1e7d07
commit 029eda1
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/...s/CSharp/Analyzers/UsePrimaryConstructor/CSharpUsePrimaryConstructorDiagnosticAnalyzer.cs b/...s/CSharp/Analyzers/UsePrimaryConstructor/CSharpUsePrimaryConstructorDiagnosticAnalyzer.cs
@@ -366,6 +366,10 @@ bool TryFindPrimaryConstructorCandidate(
                         if (primaryConstructor != null)
                             return false;
 
+                        // Check if any of the parameters is a ref-like type
+                        if (constructor.Parameters.Any(p => p.Type.IsRefLikeType))
+                            return false;
+
                         primaryConstructor = constructor;
                         primaryConstructorDeclaration = constructorDeclaration;
                     }

diff --git a/src/Analyzers/CSharp/Tests/UsePrimaryConstructor/UsePrimaryConstructorTests.cs b/src/Analyzers/CSharp/Tests/UsePrimaryConstructor/UsePrimaryConstructorTests.cs
@@ -4100,4 +4100,30 @@ class C()
             LanguageVersion = LanguageVersion.CSharp12,
         }.RunAsync();
     }
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/73614")]
+    public async Task TestNotWithRefStruct()
+    {
+        await new VerifyCS.Test
+        {
+            TestCode = """
+                using System;
+                ref struct Sample
+                {
+                    private ReadOnlySpan<char> _str;
+                
+                    public Sample(ReadOnlySpan<char> str)
+                    {
+                        _str = str;
+                    }
+                
+                    public void MoveNext()
+                    {
+                        var span = _str;
+                    }
+                }
+                """,
+            LanguageVersion = LanguageVersion.CSharp12,
+        }.RunAsync();
+    }
 }