Allow accessing ref fields through rvalues (#75316)

* Allow accessing ref fields through rvalues * Remove unnecessary block
dotnet · Oct 3, 2024 · 0d41e66 · 0d41e66
1 parent 8e4dab3
commit 0d41e66
Show file tree

Hide file tree

Showing 2 changed files with 401 additions and 24 deletions.
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs b/src/Compilers/CSharp/Portable/Binder/Binder.ValueChecks.cs
@@ -1398,6 +1398,21 @@ private bool CheckFieldValueKind(SyntaxNode node, BoundFieldAccess fieldAccess,
                 }
             }
 
+            if (RequiresReferenceToLocation(valueKind))
+            {
+                switch (fieldSymbol.RefKind)
+                {
+                    case RefKind.None:
+                        break;
+                    case RefKind.Ref:
+                    case RefKind.RefReadOnly:
+                        // ref readonly access to a ref (readonly) field is fine regardless of the receiver
+                        return true;
+                    default:
+                        throw ExceptionUtilities.UnexpectedValue(fieldSymbol.RefKind);
+                }
+            }
+
             // r/w fields that are static or belong to reference types are writeable and returnable
             if (fieldSymbol.IsStatic || fieldSymbol.ContainingType.IsReferenceType)
             {