Visit collection expression elements as r-values (#75365)

dotnet · Oct 4, 2024 · 3b64495 · 3b64495
1 parent 9530e2f
commit 3b64495
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs b/src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
@@ -3661,7 +3661,7 @@ protected override void VisitStatement(BoundStatement statement)
                         SetUnknownResultNullability(initializer);
                         Debug.Assert(node.Placeholder is { });
                         SetUnknownResultNullability(node.Placeholder);
-                        Visit(initializer.Arguments[0]);
+                        VisitRvalue(initializer.Arguments[0]);
                         break;
                     case BoundCollectionExpressionSpreadElement spread:
                         // https://github.com/dotnet/roslyn/issues/68786: We should check the spread

diff --git a/src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs b/src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
@@ -107,6 +107,16 @@ private static bool IsNullableAnalysisEnabled(CSharpCompilation compilation, str
             return method.IsNullableAnalysisEnabled();
         }
 
+        [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/75343")]
+        public void CollectionExpressionBool()
+        {
+            var source = """
+                #nullable enable
+                System.Collections.Generic.List<bool> l = [false, true, false];
+                """;
+            CreateCompilation(source).VerifyDiagnostics();
+        }
+
         [Fact]
         public void DefaultLiteralInConditional()
         {