-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add missing fallbacks * Fallback options from ILegacyGlobalOptionsWorkspaceService * Pass options to CodeCleaner APIs. * Fallback options from ILegacyGlobalOptionsWorkspaceService 2 * Fallback in tests * CodeModel * Remove CodeActionOptions.Default * Remove dependency on IGlobalOptionService from inline hints service * Remove obsolete VS UnitTesting APIs. * Remote dependency on IGlobalOption service from RemoteProcessTelemetryService * Remove ExportGlobalOptionProviderAttribute * Remove PythiaOptions * Remove DiagnosticOptions from solution snapshot * Access options via AnalyzerOptionsProvider * Split ISyntaxFormatting.cs * Simplify initializers * Fix * Move AddImportPlacementOptions to a separate file in compiler extensions * Move option providers to workspace extensions * Move CodeCleanupOptions and IdeAnalyzerOptions to workspace extensions * Layering * Replace legacy GetOptions with AnalyzerOptionsProvider; add missing options * Parameter rename, comment * Add LineFormattingOptionsProviders * CodeFixOptionsProvider, include CodeStyleOptions in CodeActionOptions, include LineFormattingOptions in ExtractMethodGenerationOptions * DocumentFormattingOptions * Move a couple of options from IdeCodeStyle to SyntaxFormatting to make them available to new document formatter * Generalize using placement option in AddImportPlacementOptions * Move PreferParameterNullChecking and AllowEmbeddedStatementsOnSameLine to CSharpSimplifierOptions * Move CodeGen options to compiler extensions * UseExpressionBody * Eliminate more calls to Document.GetOptionsAsync * Cleanup DocumentationCommentOptions * Line formatting options * DefaultConditionalExpressionWrappingLength * insert_final_newline * Add PreferThrowExpression to simplifier options * Add AddNullChecksToConstructorsGeneratedFromMembers to CodeGenOptions * GenerateEqualsAndGetHashCodeFromMembersOptions * IImplementInterfaceService * AddParameterCheckCodeRefactoringProvider * ReplaceMethodWithPropertyService * NamingStylePreferences * Eliminate legacy option helpers * Fix up ExtractMethod options * Remove SyntaxFormattingOptions ctors * Replace extra helpers with CodeFixOptionsProvider * PreferUtf8StringLiterals * RazorLineFormattingOptionsStorage * Remove usage of Document.GetOptionsAsync - 1 * Remove internal usage of DocumentOptionSet and Document.GetOptionsAsync * Simplify and unify option definition patterns * Fixes and pattern unification * Serialization and equality * Simplify * Rename * Fixes * CompletionOption fixes * Feedback
- Loading branch information
Showing
538 changed files
with
5,093 additions
and
3,911 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 142 additions & 0 deletions
142
src/Analyzers/CSharp/Analyzers/CodeStyle/CSharpAnalyzerOptionsProvider.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using Microsoft.CodeAnalysis.AddImport; | ||
| using Microsoft.CodeAnalysis.CodeStyle; | ||
| using Microsoft.CodeAnalysis.CSharp; | ||
| using Microsoft.CodeAnalysis.CSharp.CodeGeneration; | ||
| using Microsoft.CodeAnalysis.CSharp.CodeStyle; | ||
| using Microsoft.CodeAnalysis.CSharp.Formatting; | ||
| using Microsoft.CodeAnalysis.CSharp.Simplification; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Microsoft.CodeAnalysis.Options; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Diagnostics; | ||
|
|
||
| /// <summary> | ||
| /// Provides C# analyzers a convenient access to editorconfig options with fallback to IDE default values. | ||
| /// </summary> | ||
| internal readonly struct CSharpAnalyzerOptionsProvider | ||
| { | ||
| /// <summary> | ||
| /// Document editorconfig options. | ||
| /// </summary> | ||
| private readonly AnalyzerConfigOptions _options; | ||
|
|
||
| /// <summary> | ||
| /// Fallback options - the default options in Code Style layer. | ||
| /// </summary> | ||
| private readonly IdeAnalyzerOptions _fallbackOptions; | ||
|
|
||
| public CSharpAnalyzerOptionsProvider(AnalyzerConfigOptions options, IdeAnalyzerOptions fallbackOptions) | ||
| { | ||
| _options = options; | ||
| _fallbackOptions = fallbackOptions; | ||
| } | ||
|
|
||
| public CSharpAnalyzerOptionsProvider(AnalyzerConfigOptions options, AnalyzerOptions fallbackOptions) | ||
| : this(options, fallbackOptions.GetIdeOptions()) | ||
| { | ||
| } | ||
|
|
||
| // SimplifierOptions | ||
|
|
||
| public CodeStyleOption2<bool> VarForBuiltInTypes => GetOption(CSharpCodeStyleOptions.VarForBuiltInTypes, FallbackSimplifierOptions.VarForBuiltInTypes); | ||
| public CodeStyleOption2<bool> VarWhenTypeIsApparent => GetOption(CSharpCodeStyleOptions.VarWhenTypeIsApparent, FallbackSimplifierOptions.VarWhenTypeIsApparent); | ||
| public CodeStyleOption2<bool> VarElsewhere => GetOption(CSharpCodeStyleOptions.VarElsewhere, FallbackSimplifierOptions.VarElsewhere); | ||
| public CodeStyleOption2<bool> PreferSimpleDefaultExpression => GetOption(CSharpCodeStyleOptions.PreferSimpleDefaultExpression, FallbackSimplifierOptions.PreferSimpleDefaultExpression); | ||
| public CodeStyleOption2<bool> PreferParameterNullChecking => GetOption(CSharpCodeStyleOptions.PreferParameterNullChecking, FallbackSimplifierOptions.PreferParameterNullChecking); | ||
| public CodeStyleOption2<bool> AllowEmbeddedStatementsOnSameLine => GetOption(CSharpCodeStyleOptions.AllowEmbeddedStatementsOnSameLine, FallbackSimplifierOptions.AllowEmbeddedStatementsOnSameLine); | ||
| public CodeStyleOption2<bool> PreferThrowExpression => GetOption(CSharpCodeStyleOptions.PreferThrowExpression, FallbackSimplifierOptions.PreferThrowExpression); | ||
| public CodeStyleOption2<PreferBracesPreference> PreferBraces => GetOption(CSharpCodeStyleOptions.PreferBraces, FallbackSimplifierOptions.PreferBraces); | ||
|
|
||
| internal CSharpSimplifierOptions GetSimplifierOptions() | ||
| => _options.GetCSharpSimplifierOptions(FallbackSimplifierOptions); | ||
|
|
||
| // SyntaxFormattingOptions | ||
|
|
||
| public CodeStyleOption2<NamespaceDeclarationPreference> NamespaceDeclarations => GetOption(CSharpCodeStyleOptions.NamespaceDeclarations, FallbackSyntaxFormattingOptions.NamespaceDeclarations); | ||
| public CodeStyleOption2<bool> PreferTopLevelStatements => GetOption(CSharpCodeStyleOptions.PreferTopLevelStatements, FallbackSyntaxFormattingOptions.PreferTopLevelStatements); | ||
|
|
||
| // AddImportPlacementOptions | ||
|
|
||
| public CodeStyleOption2<AddImportPlacement> UsingDirectivePlacement => GetOption(CSharpCodeStyleOptions.PreferredUsingDirectivePlacement, FallbackAddImportPlacementOptions.UsingDirectivePlacement); | ||
|
|
||
| // CodeStyleOptions | ||
|
|
||
| public CodeStyleOption2<bool> ImplicitObjectCreationWhenTypeIsApparent => GetOption(CSharpCodeStyleOptions.ImplicitObjectCreationWhenTypeIsApparent, FallbackCodeStyleOptions.ImplicitObjectCreationWhenTypeIsApparent); | ||
| public CodeStyleOption2<bool> PreferNullCheckOverTypeCheck => GetOption(CSharpCodeStyleOptions.PreferNullCheckOverTypeCheck, FallbackCodeStyleOptions.PreferNullCheckOverTypeCheck); | ||
| public CodeStyleOption2<bool> AllowBlankLinesBetweenConsecutiveBraces => GetOption(CSharpCodeStyleOptions.AllowBlankLinesBetweenConsecutiveBraces, FallbackCodeStyleOptions.AllowBlankLinesBetweenConsecutiveBraces); | ||
| public CodeStyleOption2<bool> AllowBlankLineAfterColonInConstructorInitializer => GetOption(CSharpCodeStyleOptions.AllowBlankLineAfterColonInConstructorInitializer, FallbackCodeStyleOptions.AllowBlankLineAfterColonInConstructorInitializer); | ||
| public CodeStyleOption2<bool> PreferConditionalDelegateCall => GetOption(CSharpCodeStyleOptions.PreferConditionalDelegateCall, FallbackCodeStyleOptions.PreferConditionalDelegateCall); | ||
| public CodeStyleOption2<bool> PreferSwitchExpression => GetOption(CSharpCodeStyleOptions.PreferSwitchExpression, FallbackCodeStyleOptions.PreferSwitchExpression); | ||
| public CodeStyleOption2<bool> PreferPatternMatching => GetOption(CSharpCodeStyleOptions.PreferPatternMatching, FallbackCodeStyleOptions.PreferPatternMatching); | ||
| public CodeStyleOption2<bool> PreferPatternMatchingOverAsWithNullCheck => GetOption(CSharpCodeStyleOptions.PreferPatternMatchingOverAsWithNullCheck, FallbackCodeStyleOptions.PreferPatternMatchingOverAsWithNullCheck); | ||
| public CodeStyleOption2<bool> PreferPatternMatchingOverIsWithCastCheck => GetOption(CSharpCodeStyleOptions.PreferPatternMatchingOverIsWithCastCheck, FallbackCodeStyleOptions.PreferPatternMatchingOverIsWithCastCheck); | ||
| public CodeStyleOption2<bool> PreferNotPattern => GetOption(CSharpCodeStyleOptions.PreferNotPattern, FallbackCodeStyleOptions.PreferNotPattern); | ||
| public CodeStyleOption2<bool> PreferExtendedPropertyPattern => GetOption(CSharpCodeStyleOptions.PreferExtendedPropertyPattern, FallbackCodeStyleOptions.PreferExtendedPropertyPattern); | ||
| public CodeStyleOption2<bool> PreferInlinedVariableDeclaration => GetOption(CSharpCodeStyleOptions.PreferInlinedVariableDeclaration, FallbackCodeStyleOptions.PreferInlinedVariableDeclaration); | ||
| public CodeStyleOption2<bool> PreferDeconstructedVariableDeclaration => GetOption(CSharpCodeStyleOptions.PreferDeconstructedVariableDeclaration, FallbackCodeStyleOptions.PreferDeconstructedVariableDeclaration); | ||
| public CodeStyleOption2<bool> PreferIndexOperator => GetOption(CSharpCodeStyleOptions.PreferIndexOperator, FallbackCodeStyleOptions.PreferIndexOperator); | ||
| public CodeStyleOption2<bool> PreferRangeOperator => GetOption(CSharpCodeStyleOptions.PreferRangeOperator, FallbackCodeStyleOptions.PreferRangeOperator); | ||
| public CodeStyleOption2<bool> PreferUtf8StringLiterals => GetOption(CSharpCodeStyleOptions.PreferUtf8StringLiterals, FallbackCodeStyleOptions.PreferUtf8StringLiterals); | ||
| public CodeStyleOption2<string> PreferredModifierOrder => GetOption(CSharpCodeStyleOptions.PreferredModifierOrder, FallbackCodeStyleOptions.PreferredModifierOrder); | ||
| public CodeStyleOption2<bool> PreferSimpleUsingStatement => GetOption(CSharpCodeStyleOptions.PreferSimpleUsingStatement, FallbackCodeStyleOptions.PreferSimpleUsingStatement); | ||
| public CodeStyleOption2<bool> PreferLocalOverAnonymousFunction => GetOption(CSharpCodeStyleOptions.PreferLocalOverAnonymousFunction, FallbackCodeStyleOptions.PreferLocalOverAnonymousFunction); | ||
| public CodeStyleOption2<bool> PreferTupleSwap => GetOption(CSharpCodeStyleOptions.PreferTupleSwap, FallbackCodeStyleOptions.PreferTupleSwap); | ||
| public CodeStyleOption2<UnusedValuePreference> UnusedValueExpressionStatement => GetOption(CSharpCodeStyleOptions.UnusedValueExpressionStatement, FallbackCodeStyleOptions.UnusedValueExpressionStatement); | ||
| public CodeStyleOption2<UnusedValuePreference> UnusedValueAssignment => GetOption(CSharpCodeStyleOptions.UnusedValueAssignment, FallbackCodeStyleOptions.UnusedValueAssignment); | ||
| public CodeStyleOption2<bool> PreferMethodGroupConversion => GetOption(CSharpCodeStyleOptions.PreferMethodGroupConversion, FallbackCodeStyleOptions.PreferMethodGroupConversion); | ||
|
|
||
| // CodeGenerationOptions | ||
|
|
||
| internal CSharpCodeGenerationOptions GetCodeGenerationOptions() | ||
| => _options.GetCSharpCodeGenerationOptions(FallbackCodeGenerationOptions); | ||
|
|
||
| public CodeStyleOption2<ExpressionBodyPreference> PreferExpressionBodiedLambdas => GetOption(CSharpCodeStyleOptions.PreferExpressionBodiedLambdas, FallbackCodeStyleOptions.PreferExpressionBodiedLambdas); | ||
| public CodeStyleOption2<bool> PreferStaticLocalFunction => GetOption(CSharpCodeStyleOptions.PreferStaticLocalFunction, FallbackCodeStyleOptions.PreferStaticLocalFunction); | ||
|
|
||
| private TValue GetOption<TValue>(Option2<TValue> option, TValue defaultValue) | ||
| => _options.GetEditorConfigOption(option, defaultValue); | ||
|
|
||
| private CSharpIdeCodeStyleOptions FallbackCodeStyleOptions | ||
| => (CSharpIdeCodeStyleOptions?)_fallbackOptions.CodeStyleOptions ?? CSharpIdeCodeStyleOptions.Default; | ||
|
|
||
| private CSharpSimplifierOptions FallbackSimplifierOptions | ||
| => (CSharpSimplifierOptions?)_fallbackOptions.CleanupOptions?.SimplifierOptions ?? CSharpSimplifierOptions.Default; | ||
|
|
||
| private CSharpSyntaxFormattingOptions FallbackSyntaxFormattingOptions | ||
| => (CSharpSyntaxFormattingOptions?)_fallbackOptions.CleanupOptions?.FormattingOptions ?? CSharpSyntaxFormattingOptions.Default; | ||
|
|
||
| private AddImportPlacementOptions FallbackAddImportPlacementOptions | ||
| => _fallbackOptions.CleanupOptions?.AddImportOptions ?? AddImportPlacementOptions.Default; | ||
|
|
||
| private CSharpCodeGenerationOptions FallbackCodeGenerationOptions | ||
| => (CSharpCodeGenerationOptions?)_fallbackOptions.GenerationOptions ?? CSharpCodeGenerationOptions.Default; | ||
|
|
||
| public static explicit operator CSharpAnalyzerOptionsProvider(AnalyzerOptionsProvider provider) | ||
| => new(provider.GetAnalyzerConfigOptions(), provider.GetFallbackOptions()); | ||
|
|
||
| public static implicit operator AnalyzerOptionsProvider(CSharpAnalyzerOptionsProvider provider) | ||
| => new(provider._options, provider._fallbackOptions); | ||
| } | ||
|
|
||
| internal static class CSharpAnalyzerOptionsProviders | ||
| { | ||
| public static CSharpAnalyzerOptionsProvider GetCSharpAnalyzerOptions(this SemanticModelAnalysisContext context) | ||
| => new(context.Options.AnalyzerConfigOptionsProvider.GetOptions(context.SemanticModel.SyntaxTree), context.Options); | ||
|
|
||
| public static CSharpAnalyzerOptionsProvider GetCSharpAnalyzerOptions(this SyntaxNodeAnalysisContext context) | ||
| => new(context.Options.AnalyzerConfigOptionsProvider.GetOptions(context.Node.SyntaxTree), context.Options); | ||
|
|
||
| public static CSharpAnalyzerOptionsProvider GetCSharpAnalyzerOptions(this SyntaxTreeAnalysisContext context) | ||
| => new(context.Options.AnalyzerConfigOptionsProvider.GetOptions(context.Tree), context.Options); | ||
|
|
||
| public static CSharpAnalyzerOptionsProvider GetCSharpAnalyzerOptions(this CodeBlockAnalysisContext context) | ||
| => new(context.Options.AnalyzerConfigOptionsProvider.GetOptions(context.SemanticModel.SyntaxTree), context.Options); | ||
|
|
||
| public static CSharpAnalyzerOptionsProvider GetCSharpAnalyzerOptions(this OperationAnalysisContext context) | ||
| => new(context.Options.AnalyzerConfigOptionsProvider.GetOptions(context.Operation.Syntax.SyntaxTree), context.Options); | ||
| } |
Oops, something went wrong.