Skip to content

Commit

Permalink
Merge pull request #31993 from mikkelbu/clean-compile-without-IDE0055
Browse files Browse the repository at this point in the history
Compile successfully - without IDE0055 - from a fresh checkout
  • Loading branch information
sharwell authored Dec 28, 2018
2 parents 68417b0 + d9317b8 commit bff68d6
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public override void VisitField(IFieldSymbol symbol)
symbol.ContainingType.Accept(this.NotFirstVisitor);
AddPunctuation(SyntaxKind.DotToken);
}

if (symbol.ContainingType.TypeKind == TypeKind.Enum)
{
builder.Add(CreatePart(SymbolDisplayPartKind.EnumMemberName, symbol, symbol.Name));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2208,7 +2208,7 @@ IUnaryOperation (UnaryOperatorKind.Minus) (OperatorMethod: Function C.op_UnaryNe

VerifyOperationTreeForTest(Of UnaryExpressionSyntax)(source, expectedOperationTree)
End Sub

<CompilerTrait(CompilerFeature.IOperation, CompilerFeature.Dataflow)>
<Fact>
Public Sub LogicalNotFlow_01()
Expand Down Expand Up @@ -2248,7 +2248,7 @@ Block[B2] - Exit

VerifyFlowGraphAndDiagnosticsForTest(Of MethodBlockSyntax)(source, expectedFlowGraph, expectedDiagnostics)
End Sub

<CompilerTrait(CompilerFeature.IOperation, CompilerFeature.Dataflow)>
<Fact>
Public Sub LogicalNotFlow_02()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ await TestAsync(
class C
{
}",
Namespace("System"),
Namespace("System"),
Class("Obsolete"));
}

Expand All @@ -540,7 +540,7 @@ class A
{
[Obsolete]
}",
Namespace("System"),
Namespace("System"),
Class("Obsolete"));
}

Expand All @@ -555,7 +555,7 @@ await TestAsync(
class MyAttribute : Attribute
{
}",
Namespace("System"),
Namespace("System"),
Class("My"),
Class("Attribute"));
}
Expand All @@ -578,7 +578,7 @@ public class MyAttribute : Attribute
class Derived : Base
{
}",
Namespace("System"),
Namespace("System"),
Class("Base"),
Class("My"),
Method("My"),
Expand Down Expand Up @@ -1118,7 +1118,7 @@ class C
global::System.String f;
}",
Namespace("System"),
Namespace("System"),
Namespace("System"),
Class("String"));
}

Expand All @@ -1142,9 +1142,9 @@ class Nested { }
await TestAsync(code,
code,
Options.Regular,
Namespace("System"),
Namespace("System"),
Class("Str"),
Namespace("System"),
Namespace("System"),
Class("String"),
Class("Str"),
Class("Nested"),
Expand Down Expand Up @@ -1765,7 +1765,7 @@ class Obsolete : Attribute
class ObsoleteAttribute : Attribute
{
}",
Namespace("System"),
Namespace("System"),
Class("Serializable"),
Class("SerializableAttribute"),
Class("Obsolete"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ private bool TryClassifySymbol(
// For Namespace parts, we want don't want to classify the QualifiedNameSyntax
// nodes, we instead wait for the each IdentifierNameSyntax node to avoid
// creating overlapping ClassifiedSpans.
if (symbol is INamespaceSymbol namespaceSymbol &&
if (symbol is INamespaceSymbol namespaceSymbol &&
name is IdentifierNameSyntax identifierNameSyntax)
{
// Do not classify the global:: namespace. It is already syntactically classified as a keyword.
Expand Down

0 comments on commit bff68d6

Please sign in to comment.