Disable import completion by default

dotnet · Oct 21, 2020 · fad9d46 · fad9d46
1 parent aa0de62
commit fad9d46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Features/Core/Portable/Completion/CompletionOptions.cs b/src/Features/Core/Portable/Completion/CompletionOptions.cs
@@ -55,7 +55,7 @@ internal static class CompletionOptions
         //Dev16 options
 
         public static readonly PerLanguageOption2<bool?> ShowItemsFromUnimportedNamespaces =
-            new(nameof(CompletionOptions), nameof(ShowItemsFromUnimportedNamespaces), defaultValue: true,
+            new(nameof(CompletionOptions), nameof(ShowItemsFromUnimportedNamespaces), defaultValue: null,
             storageLocations: new RoamingProfileStorageLocation("TextEditor.%LANGUAGE%.Specific.ShowItemsFromUnimportedNamespaces"));
 
         // Use tri-value so the default state can be used to turn on the feature with experimentation service.

diff --git a/...ortable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs b/...ortable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs
@@ -51,8 +51,9 @@ public override async Task ProvideCompletionsAsync(CompletionContext completionC
             if (!isExpandedCompletion)
             {
                 var isImportCompletionEnabled = completionContext.Options.GetOption(CompletionOptions.ShowItemsFromUnimportedNamespaces, document.Project.Language);
-                if (isImportCompletionEnabled == false)
+                if (isImportCompletionEnabled != true)
                 {
+                    // This is a tri-value option, default value (null) means disabled
                     return;
                 }
             }