Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error list filtering results in error code allocations #31964

Closed
sharwell opened this issue Dec 20, 2018 · 2 comments
Closed

Error list filtering results in error code allocations #31964

sharwell opened this issue Dec 20, 2018 · 2 comments
Assignees
@sharwell
Labels
Area-Compilers Concept-Continuous Improvement Developer Community The issue was originally reported on https://developercommunity.visualstudio.com Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Tenet-Performance Regression in measured performance of the product from goals.
Milestone
16.0.P2

Comments

@sharwell
Copy link
Member

This method should use a cache for the ID→error code mapping to reduce allocations.

🔗 Observed in https://developercommunity.visualstudio.com/content/problem/412691/typing-lag-in-preview-2.html

roslyn/src/Compilers/Core/Portable/Diagnostic/CommonMessageProvider.cs

Lines 102 to 105 in 51638c7

public string GetIdForErrorCode(int errorCode)
{
return CodePrefix + errorCode.ToString("0000");
}

@sharwell sharwell added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-Compilers Tenet-Performance Regression in measured performance of the product from goals. Concept-Continuous Improvement Developer Community The issue was originally reported on https://developercommunity.visualstudio.com labels Dec 20, 2018
@sharwell sharwell added this to the 16.0.P3 milestone Dec 20, 2018
@sharwell
Copy link
Member Author

sharwell commented Dec 20, 2018 •
edited
Loading

/cc @333fred this was responsible for ~130MiB allocations over three minutes

@333fred
Copy link
Member

333fred commented Dec 20, 2018 •
edited
Loading

@sharwell did the trace give you any clue as to how many unique error codes were generated? ie, how big this cache would need to be?

@sharwell sharwell mentioned this issue Dec 20, 2018
Merged
sharwell added a commit to sharwell/roslyn that referenced this issue Dec 20, 2018
@sharwell
Cache the return values for GetIdForErrorCode
1b7f56c 
Fixes dotnet#31964
@sharwell sharwell modified the milestones: 16.0.P3, 16.0.P2 Jan 1, 2019
@sharwell sharwell self-assigned this Jan 1, 2019
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed help wanted The issue is "up for grabs" - add a comment if you are interested in working on it labels Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-Compilers Concept-Continuous Improvement Developer Community The issue was originally reported on https://developercommunity.visualstudio.com Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Tenet-Performance Regression in measured performance of the product from goals.
Projects
None yet
Milestone
16.0.P2
Development

No branches or pull requests
2 participants
@sharwell @333fred