IDE API Changes from Review

[333fred]

Notes added in #45211

SolutionInfo.Create

Add EditorBrowsable(Never) to the backcompat overload.

SymbolFinder.Find(Derived(Classes|Interfaces)|Interfaces)Async

We should reconsider adding multiple overloads, and instead remove the default parameters from the existing overload and introduce a new overload with transitive set to true to match current behavior.
This is our standard modus operandi for these scenarios.

Renamer.RenameDocumentAsync

Make this and the related structs internal unless we have a partner team ready to consume the API in 16.7. We can make the API public again when someone is ready to consume and validate the API shape.

[jasonmalinowski]

@ryzngard One question @CyrusNajmabadi and I had -- for the document renaming APIs, are we consuming those in 16.7 somewhere or did that work slip to 16.8? If it did slip, does it make sense to keep the APIs internal just in 16.7 before we lock them accidentally?

[CyrusNajmabadi]

@ryzngard I've taken are of the first two issues. CAn you handle the rename one?

[ryzngard]

Renamer.RenameDocumentAsync is used by Project-System already dotnet/project-system#6179 (comment)

[jasonmalinowski]

@CyrusNajmabadi Good to close then?