Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AD0001 in CSharpRemoveUnnecessarySuppressionsDiagnosticAnalyzer #45465

Closed
mavasani opened this issue Jun 25, 2020 · 3 comments · Fixed by #45613
Closed

AD0001 in CSharpRemoveUnnecessarySuppressionsDiagnosticAnalyzer #45465

mavasani opened this issue Jun 25, 2020 · 3 comments · Fixed by #45613
Assignees
@mavasani
Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Milestone
16.8.P1

Comments

@mavasani
Copy link
Contributor

Starting with Visual Studio 2019 version 16.7 Preview 2, a new analyzer (dotnet/roslyn#44287) will report cases where the target of a global suppression cannot be found. The first thing I would try is opening the solution in this version and looking for reports of IDE0076 in GlobalSuppressions.cs.

That helps. I can see 13 warnings raised by IDE0076 analyzer when I opened the solution in VS 2019 Int Preview (16.7 Preview 4). I found around 35 additional errors from AD0001 analyzer. please see attachment for errors with stack trace. Looks like an issue in IDE0076 and IDE0077 analyzers.
AD0001 errors.txt

Originally posted by @kartheekp-ms in dotnet/roslyn-analyzers#3587 (comment)
@mavasani mavasani self-assigned this Jun 25, 2020
@mavasani mavasani mentioned this issue Jun 25, 2020
Closed
mavasani added a commit to mavasani/roslyn that referenced this issue Jul 2, 2020
@mavasani
Fix AD0001 for IDE0076
55a02dc 
Fixes dotnet#45465
Ensure we normalize the target scope passed to target symbol resolver. It doesn't handle the recently added 'namespaceanddescendants' scope in legacy target string format and expects it to be normalized to 'namespace' scope.
@mavasani mavasani mentioned this issue Jul 2, 2020
Merged
@mavasani mavasani added the 4 - In Review A fix for the issue is submitted for review. label Jul 2, 2020
@mavasani mavasani added this to the 16.7.P4 milestone Jul 2, 2020
mavasani added a commit to mavasani/roslyn that referenced this issue Jul 2, 2020
@mavasani
Fix AD0001 for IDE0076
a08c596 
Fixes dotnet#45465
Ensure we normalize the target scope passed to target symbol resolver. It doesn't handle the recently added 'namespaceanddescendants' scope in legacy target string format and expects it to be normalized to 'namespace' scope.
@mavasani mavasani modified the milestones: 16.7.P4, 16.8.P1 Jul 2, 2020
@ghost ghost closed this as completed in #45613 Jul 2, 2020
@mavasani mavasani mentioned this issue Aug 18, 2020
Closed
@VitaliySmolyakov
Copy link

Thanks for fixing that. But why it's still not released?! Who is deciding in which version to release it? So frustrating...

@mavasani
Copy link
Contributor Author

mavasani commented Oct 8, 2020

This should be available in latest 16.8 Preview builds and soon in 16.8 release build, when released.

@CyrusNajmabadi
Copy link
Member

But why it's still not released?!

After we fix an issue, the code flows into the next release of VS.

Who is deciding in which version to release it? So frustrating...

Only super critical issues get preemptive patches to address this. These have to be issues like "vs crashes on start" where the product is literally fully non-functional. In this case the product is functional, albeit with an annoying bug. So that will be provided on the normal release cadence for VS. Thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
4 - In Review A fix for the issue is submitted for review. Area-IDE Bug
Projects
None yet
Milestone
16.8.P1
Development

Successfully merging a pull request may close this issue.

Fix AD0001 for IDE0076 mavasani/roslyn
3 participants
@VitaliySmolyakov @CyrusNajmabadi @mavasani