-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline Rename Dialog - mouse cursor needs to be arrow on the Apply button #981
Comments
@KirillOsenkov I'm able to fix that issue, however, I am unable to test it. When I debug RoslynLight.sln/Roslyn.sln, debugged instance of VS 2015 is loading Microsoft.CodeAnalysis.CSharp.EditorFeatures.dll from C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\PrivateAssemblies thus ignoring freshly compiled DLL. Any advice how to test the code or debug it is greatly appreciated. |
Discussed this with @alexsorokoletov on gitter. Unfortunately, there's no supported way to see changes at this layer reflected in VS. This is discussed in more detail in #1041. |
@alexsorokoletov You can always submit a PR for us try out 😄 |
I just don't want to waste your time. If you have time, you would fix this issue. Isn't that the idea behind up and grab. Btw, I was able to test my changes using Live Tree/Live Property features from CTP 6. All my changes are in XAML. |
On the contrary, you can save us time by submitting a PR. Thanks! |
Here is a pull request #1320 |
Fixed mouse cursor in Inline Rename Dialog #981
That PR is merged so this can be closed right? |
@DickvdBrink Correct. The commit that was merged didn't use one of github's recognized "Fixes ###" phrases, but that was their intent. I've additionally verified the behavior on my machine. Closing & marking as Verified now. |
If you hover over the Apply button in the Inline Rename Dashboard, the mouse cursor is set to Beam (like the rest of the editor). We should probably set the cursor to Arrow on the entire dashboard.
The text was updated successfully, but these errors were encountered: