Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Rename Dialog - mouse cursor needs to be arrow on the Apply button #981

Closed
KirillOsenkov opened this issue Mar 3, 2015 · 9 comments
Assignees
Labels
Area-IDE Bug Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Verified
Milestone

Comments

@KirillOsenkov
Copy link
Member

If you hover over the Apply button in the Inline Rename Dashboard, the mouse cursor is set to Beam (like the rest of the editor). We should probably set the cursor to Arrow on the entire dashboard.

@KirillOsenkov KirillOsenkov added Area-IDE Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. Bug labels Mar 3, 2015
@Pilchie Pilchie added this to the Unknown milestone Mar 3, 2015
@Pilchie Pilchie added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Mar 3, 2015
@alexsorokoletov
Copy link
Contributor

@KirillOsenkov I'm able to fix that issue, however, I am unable to test it. When I debug RoslynLight.sln/Roslyn.sln, debugged instance of VS 2015 is loading Microsoft.CodeAnalysis.CSharp.EditorFeatures.dll from C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\PrivateAssemblies thus ignoring freshly compiled DLL.

Any advice how to test the code or debug it is greatly appreciated.

@KirillOsenkov
Copy link
Member Author

Adding @rchande @dpoeschl

@dpoeschl
Copy link
Contributor

Discussed this with @alexsorokoletov on gitter. Unfortunately, there's no supported way to see changes at this layer reflected in VS. This is discussed in more detail in #1041.

@rchande
Copy link
Contributor

rchande commented Mar 17, 2015

@alexsorokoletov You can always submit a PR for us try out 😄

@alexsorokoletov
Copy link
Contributor

I just don't want to waste your time. If you have time, you would fix this issue. Isn't that the idea behind up and grab. Btw, I was able to test my changes using Live Tree/Live Property features from CTP 6. All my changes are in XAML.

@KirillOsenkov
Copy link
Member Author

On the contrary, you can save us time by submitting a PR. Thanks!

@alexsorokoletov
Copy link
Contributor

Here is a pull request #1320

rchande added a commit that referenced this issue Mar 20, 2015
Fixed mouse cursor in Inline Rename Dialog #981
@DickvdBrink
Copy link
Contributor

That PR is merged so this can be closed right?

@dpoeschl
Copy link
Contributor

@DickvdBrink Correct. The commit that was merged didn't use one of github's recognized "Fixes ###" phrases, but that was their intent. I've additionally verified the behavior on my machine. Closing & marking as Verified now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Concept-Diagnostic Clarity The issues deals with the ease of understanding of errors and warnings. help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Verified
Projects
None yet
Development

No branches or pull requests

6 participants