Update ITextBufferCloneService #30868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Nov 8, 2018
src/EditorFeatures/Text/Implementation/TextBufferFactoryService/ITextBufferCloneService.cs
Outdated
Show resolved
Hide resolved
...EditorFeatures/Text/Implementation/TextBufferFactoryService/TextBufferCloneServiceFactory.cs
Outdated
Show resolved
Hide resolved
sharwell
force-pushed
the
content-type
branch
from
171522f to
3e0dc3e
Compare
|
This is now updated through bf32f41 |
sharwell
force-pushed
the
content-type
branch
from
3e0dc3e to
5839f35
Compare
sharwell
commented
Nov 9, 2018
| return Clone(textImage, contentType); | ||
| } | ||
|
|
||
| // we can't, so do it more expensive way |
There was a problem hiding this comment.
Originally from #30733 (comment):
That is indeed expensive. Did this just move from somewhere else or is this new?
expensive way was the way FAR used to do. I moved this code from there. and use cheap way if possible, which is almost 100% time for FAR.
if sourcetext is not backed by editor text (like sourcetext created from tree factory or modified tree from tree tranformation), this will still clone but through more expensive way.
sandyarmstrong
added a commit
to sandyarmstrong/roslyn
that referenced
this pull request
Dec 19, 2018
Since dotnet#30868, `ContentTypeNames` has moved to this assembly. Type forwarding doesn't seem to work for IVT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Extracted from #30733