Rename an enum member to be clearer, and add docs as well. #31760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mavasani As an aside. One thing we probably also want to do is have the IDE analysis layer throw if someone does something wrong. So, for example, if you use SyntaxTreeWithoutSemanticsAnalysis but then register an action taht needs semantics, we should likely tell you you did something wrong. |
|
@CyrusNajmabadi I agree |
mavasani
approved these changes
Dec 13, 2018
|
Note: #31759 will supersede this. I prefer that approach, but it may take longer to get in due to risk. As such, i woudl still take this in the short term to help prevent further bugs from creeping in. |
|
@jinujoseph for approval for preview2. Thanks |
jinujoseph
added
Area-Compilers
Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: i decided against SyntaxTreeAnalysis as i really wanted the member to be very visible asnot being appropriate if you do anything the semantic model. With this name, my hope is that PRs are easier because someone would see this and then more readily notice if the semantic model was used.