Fix additional newlines being added when adding all missing imports #31782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-ide PTAL |
...rpTest/CodeRefactorings/AddMissingImports/CSharpAddMissingImportsRefactoringProviderTests.cs
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
mavasani
approved these changes
Dec 20, 2018
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Show resolved
Hide resolved
sharwell
approved these changes
Dec 20, 2018
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Outdated
Show resolved
Hide resolved
.../Core/Portable/CodeRefactorings/AddMissingImports/AbstractAddMissingImportsFeatureService.cs
Show resolved
Hide resolved
Co-Authored-By: JoeRobich <[email protected]>
JoeRobich
force-pushed
the
fix-addimports-newlines
branch
from
d54ce3e to
6ae468f
Compare
|
@jinujoseph @vatsalyaagrawal for approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before applying the missing imports remove any additional newlines that are introduced by add import wanting to separate the import from the rest of the code. This only occurs when there are no pre-existing imports.
Fixes #31768