Add support for /nullable:warnings and /nullable:safeonlywarnings #32071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
added
Area-Compilers
Feature - Nullable Reference Types
jcouv
reviewed
Dec 31, 2018
| @@ -63286,6 +63539,8 @@ static object M() | |||
| assertDiagnosticOptions(NullableContextOptions.Disable); | |||
| assertDiagnosticOptions(NullableContextOptions.Enable); | |||
| assertDiagnosticOptions(NullableContextOptions.SafeOnly); | |||
| assertDiagnosticOptions(NullableContextOptions.Warnings); | |||
| assertDiagnosticOptions(NullableContextOptions.SafeOnlyWarnings); | |||
There was a problem hiding this comment.
Maybe I missed it, but do we have a test that shows that safeonlywarnings produces a subset of diagnostics produced by warnings? #Resolved
There was a problem hiding this comment.
Maybe I missed it, but do we have a test that shows that safeonlywarnings produces a subset of diagnostics produced by warnings?
We do have tests to verify that NullableContextOptions.SafeOnly/NullableContextOptions.SafeOnlyWarnings and NullableContextOptions.Enable/NullableContextOptions.Warnings have similar effect on diagnostics.
I extended existing tests accordingly
In reply to: 244613425 [](ancestors = 244613425)
jcouv
approved these changes
Dec 31, 2018
cston
approved these changes
Jan 2, 2019
|
CC @jaredpar For approval |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.