Learn from non-null test through suppression operator #32078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Nullable Reference Types
cston
reviewed
Jan 2, 2019
| slotBuilder.Free(); | ||
| var slotBuilder = ArrayBuilder<int>.GetInstance(); | ||
| GetSlotsToMarkAsNotNullable(receiverOpt, slotBuilder); | ||
| if (slotBuilder.Count > 0) |
There was a problem hiding this comment.
if (slotBuilder.Count > 0) [](start = 16, length = 26)
Consider removing the check since it looks unnecessary.
cston
reviewed
Jan 2, 2019
| x!.F1(x); // 1 | ||
| x.F1(x); // 2 | ||
| x!.F1(x); | ||
| x.F1(x); | ||
| x.F1(x); |
There was a problem hiding this comment.
Perhaps remove the last x.F1(x); since it's now redundant.
cston
approved these changes
Jan 2, 2019
AlekseyTs
reviewed
Jan 2, 2019
| { | ||
| void M(int? i) | ||
| { | ||
| i!!.Value.ToString(); |
There was a problem hiding this comment.
!! [](start = 9, length = 2)
Is use of ! twice intentional?
There was a problem hiding this comment.
Yes, to verify that we see through two layers
|
Consider expanding testing to other scenarios that use |
|
approved |
jcouv
commented
Jan 2, 2019
| public string? field; | ||
| void M(C? c) | ||
| { | ||
| c?.field!.ToString(); |
There was a problem hiding this comment.
📝 This scenario makes me wonder if we should warn about unnecessary null-conditional dereference (you should remove the ?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31733