Fix UseExpressionBodyHelper.GetDiagnosticLocation for indexer declara… #32445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Port existing override [UseExpressionBodyForPropertiesHelper.GetDiagnosticLocation](http://source.roslyn.io/#Microsoft.CodeAnalysis.CSharp.Features/UseExpressionBody/Helpers/UseExpressionBodyForPropertiesHelper.cs,76) to `UseExpressionBodyForIndexersHelper` Fixes dotnet#31308
| } | ||
|
|
||
| var getAccessor = GetSingleGetAccessor(declaration.AccessorList); | ||
| return getAccessor.ExpressionBody.GetLocation(); |
There was a problem hiding this comment.
i assume we won't even get here if the indexer only has a setter?
There was a problem hiding this comment.
Yes, that seems to the implementation for the property helper too.
CyrusNajmabadi
approved these changes
Jan 15, 2019
|
@jinujoseph @vatsalyaagrawal for approval |
|
@dotnet/roslyn-ide for an additional review. |
jinujoseph
approved these changes
Jan 15, 2019
xoofx
pushed a commit
to stark-lang/stark-roslyn
that referenced
this pull request
Apr 16, 2019
Fix UseExpressionBodyHelper.GetDiagnosticLocation for indexer declara…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions
Port existing override UseExpressionBodyForPropertiesHelper.GetDiagnosticLocation to
UseExpressionBodyForIndexersHelperFixes #31308