Update target frameworks for Microsoft.Microsoft.CodeAnalysis.EditorFeatures.Text #45023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EditorFeatures/Text/Microsoft.CodeAnalysis.EditorFeatures.Text.csproj
Outdated
Show resolved
Hide resolved
jaredpar
reviewed
Jun 10, 2020
| @@ -4,7 +4,7 @@ | |||
| <PropertyGroup> | |||
| <OutputType>Library</OutputType> | |||
| <RootNamespace>Microsoft.CodeAnalysis.Text</RootNamespace> | |||
| <TargetFrameworks>net472;netcoreapp3.0</TargetFrameworks> | |||
| <TargetFrameworks>$(RoslynPortableTargetFrameworks)</TargetFrameworks> | |||
There was a problem hiding this comment.
Personally I think we should go the other way and just delete this property. Having the property is only really valuable for the one time a year where we change the .NET Core TFM. That impacts basically ... me and it's a trivial search replace operation. The downside of having the property is it makes our projects look less like standard projects that customers define. I think it's clearer to just have the TF directly in the project file.
There was a problem hiding this comment.
I'm fine going either way. However, any objection to filing a follow-up issue to inline this property since everything is currently uniform and the build passed?
jaredpar
approved these changes
Jun 10, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.