Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3438, use standard Type Conversion Functions when possible #45139

Merged
merged 6 commits into from
Jul 13, 2020
Merged

#3438, use standard Type Conversion Functions when possible #45139

merged 6 commits into from
Jul 13, 2020

Conversation

jrmoreno1
Copy link
Contributor

use standard Type Conversion Functions when possible (including CStr), and not CType.

@jrmoreno1 jrmoreno1 requested a review from a team as a code owner June 13, 2020 06:06
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jun 14, 2020
@jrmoreno1 jrmoreno1 mentioned this pull request Jun 17, 2020
Closed
@jrmoreno1
Copy link
Contributor Author

@jinujoseph what does BuddyAssigned mean?

@jinujoseph
Copy link
Contributor

@jrmoreno1 it means you have a buddy @mavasani who will help you with questions/review/connecting to right people while you help us with this fix.

@jrmoreno1
Copy link
Contributor Author

@mavasani, all of the failed tests are integration and system failures as far as I can tell. I can’t find a way to rerun the test without making a change in order to be sure, and I don’t want to do that.

@mavasani
Copy link
Contributor

@jrmoreno1 I have restarted the failed runs for you, seems like these were unrelated intermittent test failures.

@mavasani mavasani merged commit 1d7ac53 into dotnet:master Jul 13, 2020
@ghost ghost added this to the Next milestone Jul 13, 2020
@mavasani
Copy link
Contributor

Thanks for the contribution @jrmoreno1!

@jrmoreno1 jrmoreno1 deleted the dev3438 branch July 13, 2020 18:43
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

@jmarolf jmarolf jmarolf approved these changes

Assignees

@mavasani mavasani

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.8.P1
Development

Successfully merging this pull request may close these issues.
5 participants
@jrmoreno1 @jinujoseph @mavasani @jmarolf @JoeRobich