Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Constant Interpolated Strings- Versioning Check & Test Suite #45685

Merged
merged 17 commits into from
Jul 14, 2020
Merged

[Feature] Constant Interpolated Strings- Versioning Check & Test Suite #45685

merged 17 commits into from
Jul 14, 2020

Conversation

kevinsun-dev
Copy link
Contributor

@kevinsun-dev kevinsun-dev commented Jul 6, 2020 •
edited
Loading

[Feature] Constant Interpolated Strings

New in this PR:

  • Versioning Check for Constant Interpolated Strings
  • Updated Tests

@kevinsun-dev kevinsun-dev self-assigned this Jul 7, 2020
@kevinsun-dev kevinsun-dev marked this pull request as ready for review July 7, 2020 17:47
@kevinsun-dev kevinsun-dev requested a review from a team as a code owner July 7, 2020 17:47
@333fred
Copy link
Member

333fred commented Jul 7, 2020 •
edited
Loading

Done review pass (commit 7) #Closed

@333fred
Copy link
Member

333fred commented Jul 8, 2020 •
edited
Loading

Done review pass (commit 8) #Closed

@333fred
Copy link
Member

333fred commented Jul 9, 2020 •
edited
Loading

Done review pass (commit 9). Just a couple more tests. #Closed

@333fred
Copy link
Member

333fred commented Jul 10, 2020 •
edited
Loading

Done review pass (commit 11) #Closed

@333fred
Copy link
Member

333fred commented Jul 10, 2020

Done review pass (commit 12). One more small rename and I think this should be good.

333fred
333fred previously approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 15). @dotnet/roslyn-compiler for a second review.

@333fred
Copy link
Member

333fred commented Jul 10, 2020

Test failures appear legitimate.

333fred
333fred reviewed Jul 11, 2020
View reviewed changes
Compilers.sln Outdated
@@ -62,7 +62,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CSharpErrorFactsGenerator",
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CSharpSyntaxGenerator", "src\Tools\Source\CompilerGeneratorTools\Source\CSharpSyntaxGenerator\CSharpSyntaxGenerator.csproj", "{288089C5-8721-458E-BE3E-78990DAB5E2D}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IOperationGenerator", "src\Tools\Source\CompilerGeneratorTools\Source\IOperationGenerator\CompilersIOperationGenerator.csproj", "{D0A79850-B32A-45E5-9FD5-D43CB345867A}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CompilersIOperationGenerator", "src\Tools\Source\CompilerGeneratorTools\Source\IOperationGenerator\CompilersIOperationGenerator.csproj", "{D0A79850-B32A-45E5-9FD5-D43CB345867A}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem unrelated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite know how that got in there, I thought I explicitly left it out, like I had for the past several commits. Does it make enough of a difference to remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, git checkout can revert just a single file. That's a really convenient trick.

@333fred 333fred self-requested a review July 11, 2020 04:04
@333fred 333fred dismissed their stale review July 11, 2020 04:04

New things.

@333fred
Copy link
Member

333fred commented Jul 13, 2020

@dotnet/roslyn-compiler for a second review.

@gafter gafter self-requested a review July 14, 2020 17:06
gafter
gafter reviewed Jul 14, 2020
View reviewed changes
src/Compilers/CSharp/Test/Semantic/Semantics/ConstantTests.cs
}
}";
var comp = CreateCompilation(source, parseOptions: TestOptions.RegularPreview);
comp.VerifyDiagnostics();
Copy link
Member

@gafter gafter Jul 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VerifyDiagnostics [](start = 17, length = 17)

Can you also please verify diagnostics for a C# 8 compilation? Never mind, tested elsewhere. #Resolved

gafter
gafter approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kevinsun-dev kevinsun-dev merged commit 46ef3b7 into dotnet:features/interpolated-string-constants Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson left review comments

@gafter gafter gafter approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@kevinsun-dev kevinsun-dev

Labels
Area-Compilers Feature - Const Interpolated Strings Language-C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinsun-dev @333fred @gafter @RikkiGibson