Don't optimize large tuple literal switch inputs #48028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Sep 24, 2020
jaredpar
reviewed
Sep 24, 2020
| { | ||
| int x1 = (1, 2, 3, 4, 5, 6, 7, 8, 9, 10) switch | ||
| { | ||
| (1, 2, 3, 4, 5, 6, 7, 8, 9, 10) => 1, |
There was a problem hiding this comment.
Can we add a negative case here, basically a literal that won't match. Just for completeness.
jaredpar
approved these changes
Sep 24, 2020
chsienki
approved these changes
Sep 24, 2020
| } | ||
|
|
||
| [Fact, WorkItem(47878, "https://github.com/dotnet/roslyn/issues/47878")] | ||
| public void VerifyIL_8ElementsTuple_SideEffects_DefaultLabel() |
There was a problem hiding this comment.
Nit: doesn't actually verify IL
| } | ||
|
|
||
| [Fact, WorkItem(47878, "https://github.com/dotnet/roslyn/issues/47878")] | ||
| public void VerifyIL_9ElementsTuple_SideEffects_DefaultLabel() |
|
It looks like the integration queue is not running. Will force merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47878
This is a simpler, less optimal fix than #47893. We can try to figure out how to fix the optimization, but I wanted to submit this as a candidate fix for 16.8 in case the optimization is hard to get right for large tuples.