IServiceBroker/MessagePack/OOP fix roll-up #48201
Conversation
This source is unnecessary since operations will fail anyway after a disconnection occurs.
This method was corrected for 16.8 Preview 3.
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
|
|
||
| // If this is hit the cancellation token passed to the service implementation did not use the correct token. | ||
| if (exception is ConnectionLostException) |
There was a problem hiding this comment.
this is probably worth documenting why we're doing it this way. doesn't need to be in this PR though.
There was a problem hiding this comment.
It's documented a few lines above, and still under investigation.
roslyn/src/Workspaces/Remote/Core/RemoteCallback.cs
Lines 103 to 112 in 4123b1c
|
|
||
| // work around incorrect implementation in 16.8 Preview 2 | ||
| if (MultiplexingStream == multiplexingStream) | ||
| return this; |
There was a problem hiding this comment.
possibly to doc/explain/link this to something clearer?
There was a problem hiding this comment.
actually, doc the whole thing tbh, i don't undestand any of it :)
There was a problem hiding this comment.
See #47870 (comment). This is dead code by API contract and only needed because roslyn-integration-CI is on a specific version with a bug.
Pull request #48153 will revert this as soon as roslyn-integration-CI is updated to 16.8 Preview 3 or newer.
Supersedes #47870, #48179, #48187, #48188, #48195
Closes #48175