Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property parsing when it contains parantheses #48598

Merged
merged 11 commits into from
Nov 10, 2020
Merged

Fix property parsing when it contains parantheses #48598

merged 11 commits into from
Nov 10, 2020

Conversation

Youssef1313
Copy link
Member

Fixes #48587

@Youssef1313 Youssef1313 requested a review from a team as a code owner October 14, 2020 18:40
@RikkiGibson RikkiGibson added Community The pull request was submitted by a contributor who is not a Microsoft employee. Language-VB labels Oct 14, 2020
333fred
333fred approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the redundant else removed.

@333fred
Copy link
Member

333fred commented Oct 23, 2020

@dotnet/roslyn-compiler for a second review.

@AlekseyTs
Copy link
Contributor

Done with review pass (iteration 3)

@Youssef1313
Copy link
Member Author

@fred333 @AlekseyTs Can you give this another look?

@Youssef1313 Youssef1313 requested a review from AlekseyTs November 4, 2020 13:27
@AlekseyTs
Copy link
Contributor

@Youssef1313 It looks like Microsoft.CodeAnalysis.VisualBasic.UnitTests.ParserRegressionTests.ParseTrailingTextAfterPropertyWithParentheses test is failing

333fred
333fred reviewed Nov 4, 2020
View reviewed changes
src/Compilers/VisualBasic/Test/Syntax/Parser/ParserRegressionTests.vb Outdated
Public ReadOnly Property NumberOfResult1() String Integer JohnDoe WwwIIWww Wow
Public ReadOnly Property NumberOfResult2() Some unexpected tokens As Integer

Public ReadOnly Property NumberOfResult3() ' With comment - no errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a version with bad text in between the parens and the comment/line continuation below?

AlekseyTs
AlekseyTs approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 11)

@AlekseyTs AlekseyTs merged commit f609480 into dotnet:master Nov 10, 2020
@ghost ghost added this to the Next milestone Nov 10, 2020
@AlekseyTs
Copy link
Contributor

@Youssef1313 Thanks for the contribution!

@Youssef1313 Youssef1313 deleted the vb-parse branch November 10, 2020 22:04
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@mikadumont mikadumont mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Language-VB
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.

Problem on VB.net compiler with property,when no "As" keyword specified (.NET 4.8)
6 participants
@Youssef1313 @333fred @AlekseyTs @RikkiGibson @allisonchou @Dotnet-GitSync-Bot