Add import null reference exception #48967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Oct 28, 2020
| { | ||
| var awaitExpression = FirstAwaitExpressionAncestor(syntaxFactsService, node); | ||
|
|
||
| var innerExpression = syntaxFactsService.GetExpressionOfAwaitExpression(awaitExpression); | ||
|
|
||
| if (innerExpression is null) |
There was a problem hiding this comment.
This is a bonus fix. Callers to GetAwaitInfo already handle when it returns null.
davidwengier
commented
Oct 28, 2020
| { | ||
| var collectionExpression = FirstForeachCollectionExpressionAncestor(syntaxFactsService, node); | ||
|
|
||
| if (collectionExpression is null) |
There was a problem hiding this comment.
This is the real fix. Callers to GetCollectionExpressionType already handle when it returns null.
jasonmalinowski
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Fix looks good.
@davidwengier Did we have any heap dumps of the failure?
No, I think @tmat just hit it randomly yesterday. |
|
Hello @davidwengier! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
added this to the 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48891
I couldn't get a repro of this, but its a fairly obvious fix. See comments below.
First commit annotates, second commit fixes the bug.