Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup remaining myget references #49089

Merged
merged 2 commits into from
Oct 31, 2020
Merged

Cleanup remaining myget references #49089

merged 2 commits into from
Oct 31, 2020

Conversation

dibarbet
Copy link
Member

there shouldn't be any more myget related things,
so finally resolves #45573

@dibarbet dibarbet requested review from RikkiGibson and a team October 30, 2020 22:36
@dibarbet dibarbet force-pushed the remove_myget_references branch from bdb47d9 to 235d861 Compare October 30, 2020 22:37
RikkiGibson
RikkiGibson approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but am also wondering if scripts/GenerateSdkPackages/README.md should just be deleted due to being out of date?

@dibarbet
Copy link
Member Author

scripts/GenerateSdkPackages/README.md should just be deleted due to being out of date?

Ah right we don't have the change-all script any more. I'll just update it

jasonmalinowski
jasonmalinowski approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dibarbet dibarbet merged commit d7048e7 into dotnet:master Oct 31, 2020
@ghost ghost added this to the Next milestone Oct 31, 2020
@dibarbet dibarbet deleted the remove_myget_references branch October 31, 2020 00:28
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.

Remove roslyn-tools, roslyn-analyzers feeds from myget restore dependencies
5 participants
@dibarbet @jasonmalinowski @JoeRobich @RikkiGibson @allisonchou