Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report an error for ref-returning auto-properties declared in an interface. #49510

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Report an error for ref-returning auto-properties declared in an interface. #49510

merged 1 commit into from
Nov 20, 2020

Conversation

AlekseyTs
Copy link
Contributor

Fixes #49341.

@AlekseyTs AlekseyTs requested a review from a team November 20, 2020 00:11
333fred
333fred approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to doc this in https://github.com/dotnet/roslyn/blob/master/docs/compilers/CSharp/Compiler%20Breaking%20Changes%20-%20post%20VS2019.md?

@AlekseyTs
Copy link
Contributor Author

AlekseyTs commented Nov 20, 2020 •
edited
Loading

Do we need to doc this ...

I don't think so, we are not changing something that used to work.

@AlekseyTs AlekseyTs merged commit 8c47ed0 into dotnet:master Nov 20, 2020
@ghost ghost added this to the Next milestone Nov 20, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Nov 20, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into merge-master
1e9e240 
* upstream/master: (47 commits)
  Make compiler server logging explicit (dotnet#48557)
  [master] Update dependencies from dotnet/arcade (dotnet#48274)
  Handle removed project in ExternalErrorDiagnosticUpdateSource
  Report an error for ref-returning auto-properties declared in an interface. (dotnet#49510)
  Add usings on paste (dotnet#48501)
  Determinism test needs to use bootstrap compiler (dotnet#49483)
  Simplify and reduce amount of work performed by SourcePropertySymbolBase constructor. (dotnet#49360)
  Updates test
  Simplify
  Split Document/Workspace handler into only handling open/closed documents respectively.
  only report watson once.
  Additional usage of a PooledHashset. (dotnet#49459)
  Loc checkin
  Update src/Features/CSharp/Portable/CodeRefactorings/ConvertLocalFunctionToMethod/CSharpConvertLocalFunctionToMethodCodeRefactoringProvider.cs
  Preserve annotation on comment trivia when performing formatting.
  Validate arguments to IAsyncCompletionSource methods
  Determinism fixes for AnonymousTypes in VB (dotnet#49467)
  Collect nfw information for a crash we're seeing.
  Make sure to not discard text changes when no reference changes are present
  Create an unsafe method from a local function when necessary (dotnet#49389)
  ...
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - Default Interface Impl Default Interface Implementation
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.

Invalid IL is produced for ref returning static auto property in an interface
4 participants
@AlekseyTs @333fred @RikkiGibson @allisonchou