Fix ALC in ProjectReference scenarios #56662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Sep 23, 2021
src/Compilers/Core/Portable/DiagnosticAnalyzer/DefaultAnalyzerAssemblyLoader.Core.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/DiagnosticAnalyzer/DefaultAnalyzerAssemblyLoader.Core.cs
Show resolved
Hide resolved
jaredpar
approved these changes
Sep 24, 2021
cston
reviewed
Sep 27, 2021
| writeMethod.Invoke(b, new object[] { sb, "Test G" }); | ||
|
|
||
| var actual = sb.ToString(); | ||
| Assert.Equal(@"Delta: Gamma: Test G |
There was a problem hiding this comment.
You're asking which copy of Delta version 1, right? I think we can check what file paths the assemblies were loaded from using the TestAccessor, but I'd have to check.
cston
reviewed
Sep 27, 2021
| ("Delta", "1.0.0.0", delta1File.Path), | ||
| ("Epsilon", "0.0.0.0", epsilonFile.Path) | ||
| }, alcs[0].Assemblies.Select(a => (a.GetName().Name!, a.GetName().Version!.ToString(), a.Location)).Order()); | ||
| #endif |
There was a problem hiding this comment.
Consider extracting a helper method: VerifyLoadContexts(new[] { ("Delta", ..., ...), ("Epsilon", ..., ...) });
cston
approved these changes
Sep 27, 2021
chsienki
approved these changes
Sep 27, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56442
cc @jaredpar @chsienki