Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify semi-required properties #59047

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Clarify semi-required properties #59047

wants to merge 7 commits into from

Conversation

sharwell
Copy link
Member

  • Ensure AllowDefault=true parameters are consistently annotated as nullable
  • Document cases where null values produce an exception with AllowDefault=true (workaround for lack of silent part rejection in MEF 2)
  • Remove unnecessary use of AllowDefault=true when a part is exported by the same module that imports it

@sharwell sharwell requested review from a team as code owners January 24, 2022 22:41
@sharwell sharwell mentioned this pull request Mar 10, 2022
Merged
@sharwell sharwell mentioned this pull request Apr 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @davidwengier