Format document after each provider #59091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jan 26, 2022
sharwell
reviewed
Jan 27, 2022
| @@ -40,6 +40,14 @@ internal Task TestAsync<T>(string testCode, string expected, (Option2<T>, T)[]? | |||
| parseOptions); | |||
| } | |||
|
|
|||
| internal Task TestAsync(string testCode, string expected, (OptionKey, object)[]? options = null, ParseOptions? parseOptions = null) | |||
There was a problem hiding this comment.
(OptionKey, object)[]? options = null
In the future, I recommend OptionsCollection for this. Very easy to initialize a new instance and set strongly-typed values. I'll look into updating this case after this PR merges.
sharwell
requested changes
Jan 27, 2022
src/Features/Core/Portable/Formatting/AbstractNewDocumentFormattingService.cs
Outdated
Show resolved
Hide resolved
| // before we call the next provider, otherwise they might not see things as they are meant to be. | ||
| // Because formatting providers often re-use code fix logic, they are often written assuming this will | ||
| // happen. | ||
| document = await CodeAction.CleanupDocumentAsync(document, cancellationToken).ConfigureAwait(false); |
CyrusNajmabadi
approved these changes
Jan 27, 2022
sharwell
approved these changes
Jan 27, 2022
ghost
added this to the
333fred
added a commit
to YairHalberstadt/roslyn
that referenced
this pull request
Jan 28, 2022
…ess-instance-members * upstream/main: (669 commits) Fix 'hasStaticConstructor' check in MethodCompiler (dotnet#59116) Update dependencies from https://github.com/dotnet/arcade build 20220127.8 (dotnet#59134) Update StreamJsonRpc (dotnet#59073) Resources Filter cancellation exceptions in generator driver (dotnet#58843) Revert "Remove dependency on EditorFeatures from Remote.ServiceHub project (dotnet#59059)" Strings Inline Convert to switch expression Explicitly test empty string case. Fix comment Simplify test code Run all Add tests Delete test generator Add support for specifying server in tests Remove options review feedback Format document after each provider (dotnet#59091) [main] Update dependencies from dotnet/arcade (dotnet#59015) ...
|
@davidwengier I see this was closed on 17.2.P1 but is there a workaround or alternative until that's released? |
|
17.2 is released in the preview channel, so if you install Visual Studio Preview this will work. The preview channel will be promoted to the non preview channel soon, and there is no real way for an individual fix to jump ahead I'm afraid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58974