Fix NRE in DeclarationNameCompletionProvider #59361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...Features/CSharp/Portable/Completion/CompletionProviders/DeclarationNameCompletionProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Feb 8, 2022
sharwell
requested changes
Feb 8, 2022
...Features/CSharp/Portable/Completion/CompletionProviders/DeclarationNameCompletionProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Feb 8, 2022
...Portable/Completion/CompletionProviders/DeclarationNameCompletionProvider.DeclarationInfo.cs
Outdated
Show resolved
Hide resolved
|
Oh wow, this is bad. It seems the provider is actually relying on the exception to have the right behavior. |
…clarationNameCompletionProvider.DeclarationInfo.cs Co-authored-by: Sam Harwell <[email protected]>
genlu
commented
Feb 9, 2022
| @@ -636,7 +636,7 @@ class C | |||
| showCompletionInArgumentLists:=showCompletionInArgumentLists, languageVersion:=LanguageVersion.Preview) | |||
|
|
|||
| state.SendTypeChars("w") | |||
| Await state.AssertSelectedCompletionItem(displayText:="with", isHardSelected:=False) | |||
| Await state.AssertSelectedCompletionItem(displayText:="with", isHardSelected:=True) | |||
There was a problem hiding this comment.
Note the behavior change here. I believe previous behavior is wrong.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while debugging something else.