Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TS external access API for ICommentSelectionService #60687

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Add TS external access API for ICommentSelectionService #60687

merged 2 commits into from
Apr 12, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 11, 2022 •
edited
Loading

@tmat tmat requested a review from a team as a code owner April 11, 2022 18:45
@tmat tmat enabled auto-merge (squash) April 11, 2022 18:46
@CyrusNajmabadi
Copy link
Member

Note: This will need a dual insertion as otherwise tehre will be two TS exports of ICommentSelectionService at the same time.

@tmat
Copy link
Member Author

tmat commented Apr 11, 2022 •
edited
Loading

Technically it does not since IVSTypeScriptCommentSelectionServiceImplementation is not implemented by TS and therefore the TS implementation of ICommentSelectionService will be rejected.

But we need dual insertion since TS is broken now and needs this fix.

@tmat tmat mentioned this pull request Apr 11, 2022
Open
@runfoapp runfoapp bot mentioned this pull request Apr 11, 2022
Closed
@tmat tmat disabled auto-merge April 12, 2022 02:35
@tmat tmat enabled auto-merge (squash) April 12, 2022 02:36
@tmat tmat disabled auto-merge April 12, 2022 02:37
@JoeRobich JoeRobich merged commit b0cd71f into dotnet:main Apr 12, 2022
@ghost ghost added this to the Next milestone Apr 12, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.3.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @CyrusNajmabadi @dibarbet @JoeRobich