Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address PROTOTYPE comments #60707

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Address PROTOTYPE comments #60707

merged 2 commits into from
Apr 13, 2022

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Apr 12, 2022 •
edited by jcouv
Loading

Test plan #60433

@AlekseyTs AlekseyTs requested review from 333fred, jcouv and a team April 12, 2022 18:01
jcouv
jcouv approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

333fred
333fred reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done review pass. A couple of grammar fixes.

docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md Outdated Show resolved Hide resolved
docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md Outdated Show resolved Hide resolved
@AlekseyTs AlekseyTs merged commit 2a63a0c into dotnet:features/UnsignedRightShift Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred 333fred approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - UnsignedRightShift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @333fred @jcouv