Expose VirtualChars to asp.net (through EA) to facilitate route classification #61529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
May 26, 2022
| return; | ||
|
|
||
| var aspContext = new AspNetCoreEmbeddedLanguageClassificationContext( | ||
| context, new AspNetCoreVirtualCharSequence(virtualChars)); |
There was a problem hiding this comment.
@JamesNK I'm not actually exposing the service to you. Instead, i just check up front if we can get the sequence of virtual-chars. If so, then we package taht up and provide it to you in the context object for that token.
JoeRobich
approved these changes
May 26, 2022
jmarolf
approved these changes
May 26, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.