Ensure that side effects of conditional access on an instance of a nullable type are not preserved in generic code #66250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llable type are not preserved in generic code Fixes dotnet#66152.
jjonescz
reviewed
Jan 5, 2023
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_NullCoalescingOperator.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_UnaryOperator.cs
Outdated
Show resolved
Hide resolved
|
@dotnet/roslyn-compiler Please review. |
1 similar comment
|
@dotnet/roslyn-compiler Please review. |
Co-authored-by: Jan Jones <[email protected]>
jcouv
reviewed
Jan 6, 2023
| @@ -1704,6 +1704,7 @@ | |||
| matching Id that are integers unique for the containing method body. | |||
| --> | |||
| <Field Name="Id" Type="int"/> | |||
| <Field Name="ForceCopyOfNullableValueType" Type="bool"/> | |||
There was a problem hiding this comment.
📝 Note to future self: For conditional access we do want a copy when dealing with an unconstrained type, for the nullable value type scenario to behave properly.
But we also use this bound node in a few other scenarios (string concat and fixed statement) that need different semantics (we shouldn't get any copy).
333fred
approved these changes
Jan 6, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66152.