Preserve changes that are still relevant after revert of #66311 #66440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Jan 18, 2023
|
@jcouv, @dotnet/roslyn-compiler For the second review |
jcouv
reviewed
Jan 19, 2023
| _factory.Sequence(new BoundExpression[] { _factory.AssignmentExpression(cache, intermediateRef) }, cache), | ||
| receiverType, | ||
| isRef: true), | ||
| #pragma warning disable format |
There was a problem hiding this comment.
nit: What's the formatting issue? Should we file a tracking issue? #Closed
There was a problem hiding this comment.
What's the formatting issue? Should we file a tracking issue?
IDE wants the initializer on a separate line. I think it is by design, but I do not like the design. I have no intention to fight for its change though.
jcouv
reviewed
Jan 19, 2023
| private IsConditionalConstrainedCallThatMustUseTempForReferenceTypeReceiverWalker(BoundLoweredConditionalAccess conditionalAccess) | ||
| : base() | ||
| { | ||
| _conditionalAccess = conditionalAccess; |
There was a problem hiding this comment.
nit: it looks like the only part we need to hold onto is the Id #WontFix
jcouv
reviewed
Jan 19, 2023
| private bool? _result; | ||
|
|
||
| private IsConditionalConstrainedCallThatMustUseTempForReferenceTypeReceiverWalker(BoundLoweredConditionalAccess conditionalAccess) | ||
| : base() |
There was a problem hiding this comment.
nit: is the base initializer needed? #Closed
jcouv
reviewed
Jan 19, 2023
| @@ -564,6 +569,60 @@ private void EmitLoweredConditionalAccessExpression(BoundLoweredConditionalAcces | |||
| } | |||
| } | |||
|
|
|||
| private sealed class IsConditionalConstrainedCallThatMustUseTempForReferenceTypeReceiverWalker : BoundTreeWalkerWithStackGuardWithoutRecursionOnTheLeftOfBinaryOperator | |||
jcouv
approved these changes
Jan 19, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #63221.