Port Rename and Formatting tests to the new framework #67020
Conversation
|
I don't see anything about this PR taht prevents #67073 from going in. All that PR does is extract the same logic that rename has today into a reusable class, instead of embedding it into the inline-rename type. |
| await TestServices.EditorVerifier.TextEqualsAsync(@" | ||
| Imports System | ||
|
|
||
| Public Class CustomAttribute$$ |
There was a problem hiding this comment.
| Public Class CustomAttribute$$ | |
| Public Class CustomA$$ttribute |
This is what the actual result looks like in the failure. I manually tried inline rename with 17.6, the cursor position after rename is consistent with test result. I think we should adjust the baseline here
There was a problem hiding this comment.
I tested Version 17.6.0 Preview 3.0 [33505.110.main] both with and without this change, and so far I have not been able to reproduce a caret position anywhere except at the end of the line.
There was a problem hiding this comment.
That's a different test. The one here is only the behavior for attributes.
There was a problem hiding this comment.
I modified the test to support both caret placement outcomes. It's not clear how/why the caret gets placed at the end of a rename operation so I wasn't sure how to start debugging this.
ghost
added this to the 
Closes #18065
Closes #45895
Closes #67244
Closes #67245