Pool node collections in analyzer driver. #67776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
CyrusNajmabadi
commented
Apr 13, 2023
| { | ||
| executeSyntaxNodeActions(analyzer, groupedActionsForAnalyzer, nodesToAnalyze); | ||
| } | ||
| } |
There was a problem hiding this comment.
specialized the codepath where we need to filter. if we don't need to filter, we can pass the data along as is. otherwise, we make a temp copy and pass that along.
| { | ||
| executeSyntaxNodeActions(analyzer, groupedActionsForAnalyzer, nodesToAnalyze); | ||
| } | ||
| } |
There was a problem hiding this comment.
specialized the codepath where we need to filter. if we don't need to filter, we can pass the data along as is. otherwise, we make a temp copy and pass that along.
mavasani
approved these changes
Apr 14, 2023
|
@333fred @RikkiGibson ptal. |
RikkiGibson
reviewed
Apr 18, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerDriver.DeclarationAnalysisData.cs
Show resolved
Hide resolved
RikkiGibson
reviewed
Apr 18, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerDriver.DeclarationAnalysisData.cs
Show resolved
Hide resolved
RikkiGibson
reviewed
Apr 20, 2023
RikkiGibson
reviewed
Apr 20, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerDriver.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
Apr 20, 2023
RikkiGibson
reviewed
Apr 20, 2023
| } | ||
| } | ||
|
|
||
| void executeOperationsActionsByKind(AnalysisScope analysisScope, ImmutableArray<IOperation> operationsToAnalyze, GroupedAnalyzerActions groupedActions, bool arePerSymbolActions) | ||
| void executeOperationsActionsByKind(ImmutableArray<IOperation> operationsToAnalyze, GroupedAnalyzerActions groupedActions, bool arePerSymbolActions) |
There was a problem hiding this comment.
I am guessing this didn't show prominently enough in the trace to do the same optimization on it?
RikkiGibson
approved these changes
Apr 20, 2023
|
@cston ptal. |
cston
approved these changes
Apr 25, 2023
ghost
added this to the 
mavasani
added
the
Performance-Scenario-Diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses garbage allocations in this path: