Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow code fixes for source generator diagnostics #67953

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Allow code fixes for source generator diagnostics #67953

merged 1 commit into from
Apr 25, 2023

Conversation

mavasani
Copy link
Contributor

Fixes #67354

@mavasani mavasani requested a review from a team as a code owner April 25, 2023 08:37
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 25, 2023
Youssef1313
Youssef1313 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! 🎉

Only question is whether we want to "bypass" the earlier check if (!priorityProvider.MatchesPriority(analyzer)) or not?

@mavasani
Copy link
Contributor Author

Only question is whether we want to "bypass" the earlier check if (!priorityProvider.MatchesPriority(analyzer)) or not?

I believe we want to retain that check so the fixes for generator diagnostics are listed below the high priority ones (such as Add using, Rename, etc.)

@mavasani mavasani removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 25, 2023
@mavasani mavasani merged commit 1bc8f49 into dotnet:main Apr 25, 2023
@mavasani mavasani deleted the CodeFixesForGeneratorDiagnostics branch April 25, 2023 18:00
@ghost ghost added this to the Next milestone Apr 25, 2023
@dibarbet dibarbet modified the milestones: Next, 17.7 P1 Apr 25, 2023
@allisonchou allisonchou mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@arunchndr arunchndr arunchndr approved these changes

@jasonmalinowski jasonmalinowski Awaiting requested review from jasonmalinowski

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.7 P1
Development

Successfully merging this pull request may close these issues.

CodeFixProvider for diagnostics reported by IIncrementalGenerator
5 participants
@mavasani @sharwell @Youssef1313 @arunchndr @dibarbet