Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear out data from pooled object before returning to pool #67963

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 25, 2023

Otherwise stale information from prior object usage could be held onto for longer than desired.

Fixes 1500MB of storage overhead observed in a local heap dump for @sharwell

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 25, 2023 20:28
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 25, 2023
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) April 25, 2023 21:25
@CyrusNajmabadi CyrusNajmabadi merged commit a10d8fd into dotnet:main Apr 25, 2023
25 checks passed
@ghost ghost added this to the Next milestone Apr 25, 2023
@dibarbet dibarbet modified the milestones: Next, 17.7 P1 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants