-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove InterceptableAttribute #68213
Conversation
[Fact] | ||
public void FileLocalAttributeDefinitions_02() | ||
{ | ||
var source0 = """ | ||
var source1 = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing something different than before the PR. The scenario just came to my mind while working on it and rather than moving to test plan and doing it later I decided to get it done now.
What does "interceptable method" mean now? (if we decide to remove usages of that term, there's a few more below) Refers to: docs/features/interceptors.md:82 in ac5cb24. [](commit_id = ac5cb24, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 4) modulo a spec/doc question
I think we just want distinctive terms for "the method that gets intercepted" and "the method that is intercepting". |
Test plan: #67421
Removing InterceptableAttribute per discussion in #67970.
5cd9e59 and 88bd1a0 are mechanical changes so should be more skimmable.