Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache evaluated parameters for public method symbols #68256

Merged
merged 2 commits into from
May 25, 2023

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented May 18, 2023

Contributes to fixing AB#1815692.

Avoids the need to update all analyzers that use the Parameters property to avoid calling it more than once. For example:
https://github.com/dotnet/roslyn-analyzers/blob/71f45f3d826c7597cdbcfe94c220c77317413e3f/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ForwardCancellationTokenToInvocations.Analyzer.cs#L354-L376C97

@sharwell sharwell requested a review from a team as a code owner May 18, 2023 18:19
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 18, 2023
@sharwell sharwell merged commit f7635dc into dotnet:main May 25, 2023
@sharwell sharwell deleted the cache-parameters branch May 25, 2023 18:49
@ghost ghost added this to the Next milestone May 25, 2023
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants