Fix completions after unsafe in using directive
#68334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ghost
added
the
Community
| yield return new[] { "abstract" }; | ||
| yield return new[] { "class" }; | ||
| yield return new[] { "delegate" }; | ||
| yield return new[] { "file" }; |
There was a problem hiding this comment.
file would be fine. it's just a normal identifier.
There was a problem hiding this comment.
In this context file comes from a keyword recommender and therefore has keyword glyph. I think, this makes it more confusing than helpful. Also leaving file here would introduce a major inconsistency since neither file nor any other contextual keyword is shown in name context, where it can be treated as identifier
There was a problem hiding this comment.
wfm.
note: i would far prefer these tests be in their respective provider test files. In other words, we should test 'class' in the tests for 'class'.
src/EditorFeatures/CSharpTest/Completion/CompletionProviders/SymbolCompletionProviderTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
May 26, 2023
5 tasks
|
@CyrusNajmabadi PTAL/merge |
|
looking |
CyrusNajmabadi
approved these changes
Jun 6, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #67985