Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TypeDeclarationFlags.AnyMemberHasAttributes for a type with parameter list and a method-targeted attribute. #68444

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Set TypeDeclarationFlags.AnyMemberHasAttributes for a type with parameter list and a method-targeted attribute. #68444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39b1bee
Set TypeDeclarationFlags.AnyMemberHasAttributes for a type with param…
AlekseyTs Jun 5, 2023
3fd60c4
Add tests
AlekseyTs Jun 5, 2023
efe1949
Update src/Compilers/CSharp/Portable/Declarations/DeclarationTreeBuil…
AlekseyTs Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Compilers/CSharp/Portable/Declarations/DeclarationTreeBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,15 @@ private SingleTypeDeclaration VisitTypeDeclaration(TypeDeclarationSyntax node, D
{
declFlags |= SingleTypeDeclaration.TypeDeclarationFlags.HasAnyNontypeMembers;
declFlags |= SingleTypeDeclaration.TypeDeclarationFlags.HasPrimaryConstructor;

foreach (var attributeListSyntax in node.AttributeLists)
{
if (attributeListSyntax.Target?.Identifier.ToAttributeLocation() == AttributeLocation.Method)
{
declFlags |= SingleTypeDeclaration.TypeDeclarationFlags.AnyMemberHasAttributes;
AlekseyTs marked this conversation as resolved.
Show resolved Hide resolved
break;
}
}
}

var memberNames = GetNonTypeMemberNames(
Expand Down
115 changes: 115 additions & 0 deletions src/Compilers/CSharp/Test/Semantic/Semantics/PrimaryConstructorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3428,6 +3428,121 @@ class C(int someParam)
Assert.Equal(@"A(""someParam"")", c.PrimaryConstructor.GetAttributes().Single().ToString());
}

[Theory]
[CombinatorialData]
[WorkItem("https://github.com/dotnet/roslyn/issues/68349")]
public void AttributesOnPrimaryConstructor_11([CombinatorialValues("class C();", "struct C();", "record C();", "record class C();", "record struct C();")] string declaration)
{
string source = @"
_ = new C();

[method: System.Obsolete(""Obsolete!!!"", error: true)]
" + declaration + @"
";
var comp = CreateCompilation(source);
comp.VerifyDiagnostics(
// (2,5): error CS0619: 'C.C()' is obsolete: 'Obsolete!!!'
// _ = new C();
Diagnostic(ErrorCode.ERR_DeprecatedSymbolStr, "new C()").WithArguments("C.C()", "Obsolete!!!").WithLocation(2, 5)
);

var c = (SourceMemberContainerTypeSymbol)comp.GetTypeByMetadataName("C");
Assert.True(c.AnyMemberHasAttributes);
}

[Theory]
[CombinatorialData]
public void AttributesOnPrimaryConstructor_12([CombinatorialValues("class", "struct", "record", "record class", "record struct")] string declaration)
{
string source = @"
_ = new C1();

partial " + declaration + @" C1();

#line 100
[method: System.Obsolete(""Obsolete!!!"", error: true)]
partial " + declaration + @" C1
#line 200
;
";
var comp = CreateCompilation(source);
comp.VerifyDiagnostics(
// (100,2): warning CS0657: 'method' is not a valid attribute location for this declaration. Valid attribute locations for this declaration are 'type'. All attributes in this block will be ignored.
// [method: System.Obsolete("Obsolete!!!", error: true)]
Diagnostic(ErrorCode.WRN_AttributeLocationOnBadDeclaration, "method").WithArguments("method", "type").WithLocation(100, 2)
);

var c1 = (SourceMemberContainerTypeSymbol)comp.GetTypeByMetadataName("C1");
Assert.False(c1.AnyMemberHasAttributes);
}

[Theory]
[CombinatorialData]
public void AttributesOnPrimaryConstructor_13([CombinatorialValues("class", "struct", "record", "record class", "record struct")] string declaration)
{
string source = @"
_ = new C1();

[method: System.Obsolete(""Obsolete!!!"", error: true)]
partial " + declaration + @" C1();

partial " + declaration + @" C1;
";
var comp = CreateCompilation(source);
comp.VerifyDiagnostics(
// (2,5): error CS0619: 'C1.C1()' is obsolete: 'Obsolete!!!'
// _ = new C1();
Diagnostic(ErrorCode.ERR_DeprecatedSymbolStr, "new C1()").WithArguments("C1.C1()", "Obsolete!!!").WithLocation(2, 5)
);

var c1 = (SourceMemberContainerTypeSymbol)comp.GetTypeByMetadataName("C1");
Assert.True(c1.AnyMemberHasAttributes);
}

[Theory]
[CombinatorialData]
[WorkItem("https://github.com/dotnet/roslyn/issues/68349")]
public void AttributesOnPrimaryConstructor_14([CombinatorialValues("class C();", "struct C();", "record C();", "record class C();", "record struct C();")] string declaration)
{
string source = @"
_ = new C();

[System.Obsolete(""Obsolete!!!"", error: true)]
" + declaration + @"
";
var comp = CreateCompilation(source);
comp.VerifyDiagnostics(
// (2,9): error CS0619: 'C' is obsolete: 'Obsolete!!!'
// _ = new C();
Diagnostic(ErrorCode.ERR_DeprecatedSymbolStr, "C").WithArguments("C", "Obsolete!!!").WithLocation(2, 9)
);

var c = (SourceMemberContainerTypeSymbol)comp.GetTypeByMetadataName("C");
Assert.False(c.AnyMemberHasAttributes);
}

[Theory]
[CombinatorialData]
[WorkItem("https://github.com/dotnet/roslyn/issues/68349")]
public void AttributesOnPrimaryConstructor_15([CombinatorialValues("class C();", "struct C();", "record C();", "record class C();", "record struct C();")] string declaration)
{
string source = @"
_ = new C();

[type: System.Obsolete(""Obsolete!!!"", error: true)]
" + declaration + @"
";
var comp = CreateCompilation(source);
comp.VerifyDiagnostics(
// (2,9): error CS0619: 'C' is obsolete: 'Obsolete!!!'
// _ = new C();
Diagnostic(ErrorCode.ERR_DeprecatedSymbolStr, "C").WithArguments("C", "Obsolete!!!").WithLocation(2, 9)
);

var c = (SourceMemberContainerTypeSymbol)comp.GetTypeByMetadataName("C");
Assert.False(c.AnyMemberHasAttributes);
}

[Fact]
public void AnalyzerActions_01_Class()
{
Expand Down