Add more interceptors tests #68462
Merged
Add more interceptors tests #68462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
5 tasks
This comment was marked as resolved.
This comment was marked as resolved.
RikkiGibson
commented
Jun 9, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceMethodSymbolWithAttributes.cs
Outdated
Show resolved
Hide resolved
…lWithAttributes.cs
cston
approved these changes
Jun 9, 2023
jcouv
reviewed
Jun 12, 2023
| C.M(); // 1 | ||
|
|
||
| class C | ||
| { |
There was a problem hiding this comment.
nit: unnecessary blank line below #Closed
There was a problem hiding this comment.
Removed, thanks.
jcouv
reviewed
Jun 12, 2023
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs
Show resolved
Hide resolved
jcouv
reviewed
Jun 12, 2023
RikkiGibson
commented
Jun 12, 2023
src/Compilers/CSharp/Test/Semantic/Semantics/InterceptorsTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #67421
Added error when using UnmanagedCallersOnly on an interceptor.
Added warnings when tuple names differ between original and interceptor methods.
Added other misc tests.
Pack errors
The remaining prototype comments are either addressed or moved to the test plan under the relevant items. For example, the prototype comment in MemberSignatureComparer will likely be impacted when we make the generics changes for .NET 8, so I moved it to under a generics bullet in the test plan.
May be a good idea to review d47ca0d standalone as it is just a mechanical packing of the error codes.