Reduce allocations in outlining in pathlogical files #68522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jun 9, 2023
| @@ -19,7 +20,8 @@ internal sealed class StringLiteralExpressionStructureProvider : AbstractSyntaxN | |||
| CancellationToken cancellationToken) | |||
| { | |||
| if (node.IsKind(SyntaxKind.StringLiteralExpression) && | |||
| !node.ContainsDiagnostics) | |||
| !node.ContainsDiagnostics && | |||
| CouldBeMultiLine()) | |||
There was a problem hiding this comment.
we don't bother running on string literals we know to be single line.
sharwell
requested changes
Jun 9, 2023
|
|
||
| namespace Microsoft.CodeAnalysis.Structure | ||
| { | ||
| internal sealed class BlockStructureContext | ||
| internal readonly ref struct BlockStructureContext |
There was a problem hiding this comment.
❗ Use a non-copyable non-ref struct
CyrusNajmabadi
force-pushed
the
stringFolding
branch
from
fb2c569 to
ad342f0
Compare
sharwell
approved these changes
Jun 9, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing traces where the allocations here show up. This would happen in files that have a massive amount of string literals in them. Mitigating cases where we could not need code folding here.