Fix 'use primary constructor' in the presence of directives #68612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
referenced
this pull request
in dotnet/roslyn-analyzers
Jun 14, 2023
mavasani
reviewed
Jun 14, 2023
| @@ -381,12 +379,17 @@ void RegisterFieldOrPropertyAnalysisIfNecessary(Analyzer? analyzer) | |||
| Dictionary<ISymbol, IParameterSymbol> candidateMembersToRemove) | |||
| { | |||
| var semanticModel = compilation.GetSemanticModel(primaryConstructorDeclaration.SyntaxTree); | |||
|
|
|||
| var body = primaryConstructorDeclaration.ExpressionBody ?? (SyntaxNode?)primaryConstructorDeclaration.Body; | |||
| if (body?.ContainsDirectives is true) | |||
There was a problem hiding this comment.
Will this also turn off the diagnostic in presence of pragma directives? Is that desirable? Not a big deal either way though.
There was a problem hiding this comment.
probably. but we can see if that's a big enough negative if people have an issue with it.
mavasani
approved these changes
Jun 14, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.