Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in ArrayBuilder.AddMany #68625

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Reduce allocations in ArrayBuilder.AddMany #68625

merged 1 commit into from
Jun 15, 2023

Conversation

jdrobison
Copy link
Contributor

@jdrobison jdrobison commented Jun 14, 2023 •
edited by Pilchie
Loading

Call EnsureCapacity in ArrayBuilder.AddMany so we have at most one array reallocation.

Fixes AB#1830263

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 14, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 14, 2023
@sharwell sharwell merged commit 7e3224c into dotnet:main Jun 15, 2023
@ghost ghost added this to the Next milestone Jun 15, 2023
@sharwell
Copy link
Member

Thanks @jdrobison !

@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@jdrobison @sharwell @CyrusNajmabadi @RikkiGibson