Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize C# Interactive window title #69066

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Localize C# Interactive window title #69066

merged 2 commits into from
Jul 25, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 17, 2023 •
edited by Pilchie
Loading

Fixes AB#1631087

@tmat tmat requested a review from a team as a code owner July 17, 2023 16:45
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 17, 2023
@tmat tmat enabled auto-merge (squash) July 17, 2023 18:46
sharwell
sharwell previously requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending resolution of https://github.com/dotnet/roslyn/pull/69066/files#r1265770714

@tmat
Copy link
Member Author

tmat commented Jul 21, 2023

@sharwell As the AzDO issues shows F# interactive has the window title localized. I think we should do the same.

@Cosifne
Copy link
Member

Cosifne commented Jul 24, 2023

@sharwell As the AzDO issues shows F# interactive has the window title localized. I think we should do the same.

I prefer to wait for @genlu to come back from vacation and check this.

@sharwell sharwell disabled auto-merge July 25, 2023 20:36
@sharwell sharwell dismissed their stale review July 25, 2023 20:36

Feedback addressed

@tmat tmat merged commit 1143904 into dotnet:main Jul 25, 2023
@tmat tmat deleted the InteractiveLoc branch July 25, 2023 20:41
@ghost ghost added this to the Next milestone Jul 25, 2023
@allisonchou allisonchou mentioned this pull request Aug 2, 2023
Closed
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosifne Cosifne Cosifne left review comments

@genlu genlu genlu approved these changes

@sharwell sharwell sharwell left review comments

Assignees
No one assigned
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P2
Development

Successfully merging this pull request may close these issues.
5 participants
@tmat @Cosifne @genlu @sharwell @dibarbet